Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #3578

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix typos #3578

merged 1 commit into from
Jan 13, 2025

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jan 8, 2025

Fix all typos found with the help of https://github.com/crate-ci/typos, also added a _typos.yaml with appropriate exclusions.

If you like this, the typos check can also be added to GH Actions with: https://github.com/crate-ci/typos/blob/master/docs/github-action.md

@majst01 majst01 requested a review from bufdev as a code owner January 8, 2025 11:50
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bufdev
bufdev reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate this, we don't have the bandwidth to integrate the actual typos tool at this exact point in time, it would need to be integrated into our Makefile system. We can merge the actual typos fixes though.

_typos.toml Outdated
@@ -0,0 +1,24 @@
[default]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file since we aren't integrating the tool for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bufdev bufdev changed the title Fix all typos Fix typos Jan 13, 2025
doriable
doriable approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests and verified locally, thank you for the contribution!

@doriable doriable merged commit 67b1b5e into bufbuild:main Jan 13, 2025
4 checks passed
@majst01 majst01 deleted the fix-typos branch January 13, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriable doriable doriable approved these changes

@bufdev bufdev bufdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majst01 @CLAassistant @bufdev @doriable