Expand ignore_empty into ignore to handle other semantics #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
approved these changes
Dec 1, 2023
Co-authored-by: Edward McFarlane <[email protected]>
rodaine
added a commit
that referenced
this pull request
Feb 16, 2024
Follow up to #137 to add matching (exhaustive) conformance tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #124 et al,
ignore_emptysemantics have been made consistent withrequired, but it's still limiting (and confusing) in situations where skipping validation rules is still desired when a field is either unpopulated or set to the default value (for instance, within an update request that allows conditionally updating a field on a resource that is itself a nullable field).This patch deprecates
ignore_empty, expanding intoignorewhich is now an enum that supports the original semantics, as well as this expanded~looser definition.ignore_emptywill be removed from the proto with a v1 release.Conformance + examples will be added after this is released (due to the two-phased managed module)