[Do not merge] Prototype GitHub workflows #106
Conversation
Alternative workflow testing for the unfied GitHub actions project.
emcfarlane
force-pushed
the
ed/workflows
branch
from
b0dd00a
to
9ecfca1
Compare
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
I think it will be better to have a single workflow file for all pushes.
Needing to hard code main here isn't great. In a unified workflow we can use ${{ github.event.repository.default_branch }} to detect if we are on the right branch and behave accordingly.
There was a problem hiding this comment.
Starter workflows have $default-branch templating: https://docs.github.com/en/actions/using-workflows/creating-starter-workflows-for-your-organization#creating-a-starter-workflow
And other workflow files will specify the default as part of their config. I don't think it's possible to access the github event as part of the specification of what events it listens on as the definition would be circular.
There was a problem hiding this comment.
Is buf-action using starter workflows?
I don't think it's possible to access the github event as part of the specification of what events it listens on as the definition would be circular.
No you can't, but you can use if: statements for the jobs or steps.
https://stackoverflow.com/questions/64781462/github-actions-default-branch-variable
There was a problem hiding this comment.
Not currently, but it's something we could provide in addition to reusable workflows. I could see the use case where a user wants to edit the pre-defined workflow and this would provide an eject mechanism.
| version: 1.32.0-beta.1 | ||
| - run: buf --version | ||
| - name: Buf delete | ||
| run: echo "Action not supported for buf" |
There was a problem hiding this comment.
I would add a comment for the command that we want to run when it is implemented (presumably buf beta registry label archive)
Continuation on #105 to help test alternative flows.
This PR syncs all pushes of branches and tags. Any delete events will archive the label. Pull requests run checks, and finally only pushes to main additionally run checks.