fix: transaction account dedupe and roles #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, if the same account is used twice in an instruction, and twice in the accounts list, Mollusk will not unify the roles of the accounts. For example, consider the following instruction:
If the same key was provided for both accounts 1 & 2, they would be serialized into the VM as separate accounts with the following roles:
Instead they should both be writable and both be signer.
Summary of Changes
Partially reimplement the transaction compilation used in
Message::new_with_blockhash
to build out the transaction context for Mollusk invokes.