Added test program crates for token and memo #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Oct 30, 2024
Comment on lines
+1
to
+3
| #[cfg(feature = "associated-token")] | ||
| pub mod associated_token; | ||
| // Last updated at mainnet-beta slot height: 298486032 |
There was a problem hiding this comment.
nit: can we move this to the top as a crate/module doc? ie:
Suggested change
| #[cfg(feature = "associated-token")] | |
| pub mod associated_token; | |
| // Last updated at mainnet-beta slot height: 298486032 | |
| //! Last updated at mainnet-beta slot height: 298486032 | |
| #[cfg(feature = "associated-token")] | |
| pub mod associated_token; |
Comment on lines
+1
to
+3
| // Last updated at mainnet-beta slot height: 298485997 | ||
| #[cfg(feature = "memo")] | ||
| pub mod memo; |
There was a problem hiding this comment.
Same here on the doc type please.
Suggested change
| // Last updated at mainnet-beta slot height: 298485997 | |
| #[cfg(feature = "memo")] | |
| pub mod memo; | |
| //! Last updated at mainnet-beta slot height: 298485997 | |
| #[cfg(feature = "memo")] | |
| pub mod memo; |
There was a problem hiding this comment.
Also will have to just adjust the scripts a bit.
| solana program dump TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA ./src/elf/token.so -u mainnet-beta | ||
| solana program dump TokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb ./src/elf/token_2022.so -u mainnet-beta | ||
| solana program dump ATokenGPvbdGVxr1b2hvZbsiqW5xWH25efTNsLJA8knL ./src/elf/associated_token.so -u mainnet-beta | ||
| solana slot -u mainnet-beta | xargs -I {} sed -i '' 's|// Last updated at mainnet-beta slot height: .*|// Last updated at mainnet-beta slot height: {}|' ./src/lib.rs |
| @@ -0,0 +1,15 @@ | |||
| [package] | |||
| name = "mollusk-memo" | |||
There was a problem hiding this comment.
Suggested change
| name = "mollusk-memo" | |
| name = "mollusk-svm-programs-memo" |
| pub fn add_program(mollusk: &mut Mollusk) { | ||
| mollusk.add_program_with_elf_and_loader( | ||
| &ID, | ||
| include_bytes!("elf/memo.so"), |
There was a problem hiding this comment.
This macro adds a static slice, so we could optionally just make this a constant in the module, since it might be a little funky for devs trying to access the ELF again through the target/debug folder.
| mollusk_svm::program::create_program_account_loader_v3(&ID) | ||
| } | ||
|
|
||
| /// Get the key and account for the system program. |
There was a problem hiding this comment.
Suggested change
| /// Get the key and account for the system program. | |
| /// Get the key and account for the SPL Token-2022 program. |
| pub fn keyed_account() -> (Pubkey, AccountSharedData) { | ||
| ( | ||
| ID, | ||
| mollusk_svm::program::create_program_account_loader_v3(&ID), |
There was a problem hiding this comment.
This is the only module where you don't offer an account() helper. Can we include it?
| pub fn keyed_account() -> (Pubkey, AccountSharedData) { | ||
| ( | ||
| ID, | ||
| mollusk_svm::program::create_program_account_loader_v3(&ID), |
There was a problem hiding this comment.
Actually looks like this one doesn't have account() either.
Co-authored-by: Joe C <[email protected]>
Co-authored-by: Joe C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.