Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reworked configuration docs. #245

Merged
merged 4 commits into from
Jan 11, 2019
Merged

Conversation

arturdryomov
Copy link
Contributor

No description provided.

Files are placed in the `.mainframer` directory.
The final configuration is the combination of files placed in:

* `${HOME}/.mainframer` — the global configuration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, that I would probably like to change to ~/.config/mainframer

A lot of other tools store configs there (example from my machine):

tree -L 1 ~/.config
/Users/user/.config
├── alacritty
├── gcloud
├── gtk-2.0
├── htop
├── kitty
├── nvim
└── thefuck

Can't find it being described as some standard other than by XDG https://unix.stackexchange.com/questions/68721/where-should-user-configuration-files-go but a lot of tools seem to use it now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Yes, it is XDG-only, but I don’t mind a semi-clean home directory on macOS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My example is from macOS just in case :)

* `${HOME}/.mainframer` — the global configuration;
* `.mainframer` — the project configuration.

It is posssible to share the configuration using the global one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reword?

"It is possible to declare common configuration using the global one and fine-tune it using the project one"


Name | Optional | Value | Default | Description
-------------------|----------|---------|---------|------------------
`remote.name` | No | `string`| — | Remote machine name from SSH config.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Hostname/IP or remote machine name from $HOME/.ssh/config."

compression: {level}
```

Name | Optional | Value | Default | Description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it's "Required" instead of "Optional" :)

> `1` gives best speed, `9` gives best compression, `0` gives no compression at all
> (the input data is simply copied a block at a time).

## `.mainframer/ignore.yml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section misses description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files are described in the .mainframer section above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess I just wanted to see description there, ok let's go without it for now then

@arturdryomov
Copy link
Contributor Author

@artem-zinnatullin, updated.

@@ -0,0 +1,69 @@
Files are placed in the `.mainframer` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is overlapped with next paragraph and also is incorrect in case of ${HOME}/.config/mainframer

Name | Required | Value | Default | Description
-------------------|----------|---------|---------|------------------
`remote.name` | Yes | `string`| — | Remote machine name from SSH config or hostname / IP address.
`push.compression` | No | `0..9` | `0` | Compression level used to copy files from local machine to remote one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is 3

-------------------|----------|---------|---------|------------------
`remote.name` | Yes | `string`| — | Remote machine name from SSH config or hostname / IP address.
`push.compression` | No | `0..9` | `0` | Compression level used to copy files from local machine to remote one.
`pull.compression` | No | `0..9` | `0` | Compression level used to copy files from remote machine to local one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these our values? Do you have a reference otherwise? I’ve found an outdated email. The source code says otherwise — seems to be -1 (Z_DEFAULT_COMPRESSION value).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MF 2.x uses 1 by default for both cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in 3.x PR #239, idea is that usually you push text files which are very compressible and pull binaries which are barely compressible, thus push 3 and pull 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update this doc in #239, going to merge your PR now

@artem-zinnatullin artem-zinnatullin merged commit 88b85fb into 3.x Jan 11, 2019
@artem-zinnatullin artem-zinnatullin deleted the ad/docs-configuration branch January 11, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants