Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Als006 #77

Merged
merged 7 commits into from
Sep 24, 2023
Merged

Als006 #77

merged 7 commits into from
Sep 24, 2023

Conversation

aothms
Copy link
Collaborator

@aothms aothms commented Sep 20, 2023

nb: pull request includes ALS005, please ignore in review

Ghesselink
Ghesselink approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@Ghesselink Ghesselink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's great to see that we're effectively reusing most of the Python code we've previously written.

It was only missing documentation for the testfiles. I've commited it to the branch of this PR.

features/steps/thens/attributes.py Show resolved Hide resolved
pjanck
pjanck approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignored ALS005 content as instructed.

features/ALS006_Alignment-horizontal-shape-representation.feature Show resolved Hide resolved
test/files/als006/README.md Show resolved Hide resolved
@Ghesselink Ghesselink merged commit 9ddeea4 into main Sep 24, 2023
2 checks passed
@Ghesselink Ghesselink deleted the als006 branch September 24, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghesselink Ghesselink Ghesselink approved these changes

@pjanck pjanck pjanck approved these changes

@JTurbakiewicz JTurbakiewicz Awaiting requested review from JTurbakiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aothms @Ghesselink @pjanck