feat: add skip_path option in watch
#27
Open
+144
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomowatt
reviewed
Oct 7, 2024
tomowatt
reviewed
Oct 7, 2024
There was a problem hiding this comment.
@jamietanna cheers for raising this, the README changes need reviewed but everything is all good!
|
Thank you! Will make those tweaks now. As an aside, @tomowatt, the Buildkite pipeline's not public - not sure if intended or not :) |
|
The reason that CI is failing is because of the fork issue we've seen elsewhere, I'll fix that up |
jamietanna
force-pushed
the
feat-skip-path
branch
from
80e72f9
to
3417451
Compare
As part of buildkite-plugins#20, we want to be able to negate specific paths in a given `watch` path by using `skip_path`. This PR adds support for specifying a `skip_path` option that support either a path or a list of paths that shouldn't result in adding the `trigger` step as part of the dynamically generated pipeline. Note even in cases where a line in the `diff` is skipped due to `skip_path` and there are other paths in the `diff` that match `path` but doesn't match `skip_path`, the step will still be added to the dynamically generated pipeline. i.e. for the step to be effectively ignored, the paths in `skip_path` should match all of those in the given `diff`. This is required due to the lack of support for negation cases in `doublestar`, which we use for glob pattern matching[0]. Closes buildkite-plugins#20. [0]: bmatcuk/doublestar#49
jamietanna
force-pushed
the
feat-skip-path
branch
from
3417451
to
a3f5af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a
skip_pathoption that support either a path or a list of paths that shouldn't result in adding thetriggerstep as part of the dynamically generated pipeline.Note even in cases where a line in the
diffis skipped due toskip_pathand there are other paths in thediffthat matchpathbut doesn't matchskip_path, the step will still be added to the dynamically generated pipeline. i.e. for the step to be effectively ignored, the paths inskip_pathshould match all of those in the givendiff.Motivation
The motivation for this is the lack of support for negation cases in
doublestar(the package used for glob pattern matching) See bmatcuk/doublestar#49.I had a use case where I needed to avoid changes in certain subdirectories to trigger a step (if there were the only changes in the diff) and I tried to use the following pattern:
path: "/main/{*,!(subdir1|subdir2)/**/*}"which should be a valid glob for filtering outsubdir1andsubdir2, but didn't work.With this, I could instead do something like:
and the result would be the same.
This is a
git cherry-pickfrom adikari#88This will close #20.