Refine informer usage in deduper #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
refine-deduper-informer
branch
from
14a52fc to
729c164
Compare
wolfeidau
requested changes
Nov 26, 2024
| // Change state from in-flight to not in-flight. | ||
| numInFlight, ok := d.casa(id, false) | ||
| if !ok { | ||
| d.logger.Debug("markComplete: job was already not-in-flight!", | ||
| d.logger.Debug("markNotRunning: job was already not-in-flight!", |
There was a problem hiding this comment.
Is this double negative something which is easy to understand?
There was a problem hiding this comment.
Fair point, I've renamed it back to markFinished (markComplete sounded to me as though the job succeeded, when it might not have).
There was a problem hiding this comment.
Or maybe it should be unmarkRunning? 🤔
There was a problem hiding this comment.
Maybe including the method name is not useful, given that zap includes the file and line number.
DrJosh9000
force-pushed
the
refine-deduper-informer
branch
from
729c164 to
c96f3d5
Compare
DrJosh9000
force-pushed
the
refine-deduper-informer
branch
from
c96f3d5 to
98dbb84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply things learned in #432 to the deduper, mainly to reduce debug log noise.
Since we can use the information provided by Informer to tell when a job transitions between running and not-running without having to consult the deduping map, we can avoid logging "was already {,not-}in-flight!" when the lack of a state change is expected.