Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM policies on Secret Manager on single Elastic CI Stack note #2161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

james2791
Copy link
Contributor

This change:

  • Adds a note underneath the main page within the docs/pages/agent/v3/aws/secrets_manager.md page (Storing agent tokens) to clarify the need for only one IAM role to be set in a corresponding secret's policy.
  • Came out from community forum discussion and testing (Autoscaling Lambda/components not made in the single case)

@render
Copy link

render bot commented May 30, 2023

@github-actions github-actions bot added the agent label May 30, 2023
Comment on lines +49 to +50
>📘 Single instance Elastic CI Stacks
> If you have set `minSize` and `maxSize` parameters equal to 1 in your [Elastic CI Stack parameters](/docs/agent/v3/elastic-ci-aws/parameters), you will only need to set the `IAMRole` to your Secret Manager secret's resource policy as above. The `AutoscalingLambdaExecutionRole` IAM role and corresponding autoscaling resources are not created in this Elastic CI Stack setup.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a little simpler/clearer:

Suggested change
>📘 Single instance Elastic CI Stacks
> If you have set `minSize` and `maxSize` parameters equal to 1 in your [Elastic CI Stack parameters](/docs/agent/v3/elastic-ci-aws/parameters), you will only need to set the `IAMRole` to your Secret Manager secret's resource policy as above. The `AutoscalingLambdaExecutionRole` IAM role and corresponding autoscaling resources are not created in this Elastic CI Stack setup.
>📘 Single instance stacks
> If you have set `minSize` and `maxSize` [parameters](/docs/agent/v3/elastic-ci-aws/parameters) equal to `1`, don't include the `AutoscalingLambdaExecutionRole` IAM role in the resource policy. Only the `IAMRole` is required since this setup doesn't need autoscaling resources.

But it's a little less precise, so happy to go with your version if you think it works better. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants