Merge pull request #73 from buildkite/defer-close-on-tickers

Defer call to stop ticker when spot listener returns
buildkite · Feb 25, 2019 · 8513ff8 · 8513ff8
2 parents 352ecac + 85752ab
commit 8513ff8
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/spot.go b/spot.go
@@ -39,14 +39,15 @@ func (l *SpotListener) Start(ctx context.Context, notices chan<- TerminationNoti
 	if !l.metadata.Available() {
 		return errors.New("ec2 metadata is not available")
 	}
-
-	tockChan := time.NewTicker(l.interval).C
-
+
+	ticker := time.NewTicker(l.interval)
+	defer ticker.Stop()
+
 	for {
 		select {
 		case <-ctx.Done():
 			return nil
-		case <-tockChan:
+		case <-ticker.C:
 			log.Debug("Polling ec2 metadata for spot termination notices")
 
 			out, err := l.metadata.GetMetadata("spot/termination-time")