Embed PEV2 plan viewer into Explain -> Visualize #9
Conversation
| /> | ||
| <link rel="stylesheet" href="https://unpkg.com/pev2/dist/style.css" /> | ||
|
|
||
| <div id="pev2" class="d-flex flex-column" style="height: 50vh"> |
There was a problem hiding this comment.
Styles look good to me! Just wondering what d-flex is though? I can't tell if it's a typo of a special type of flexbox 😅
There was a problem hiding this comment.
Just wondering what
d-flexis though?
Maybe a bootstrap thing? https://getbootstrap.com/docs/4.0/utilities/flex/
There was a problem hiding this comment.
Ohh true, I forgot the admin uses bootstrap
There was a problem hiding this comment.
Yeh, but also this thing includes it's own bootstrap on line 7 😅
I literally pulled this code verbatim from https://github.com/dalibo/pev2?tab=readme-ov-file#without-building-tools as a hacky way to see if it worked.
It feels very ugly, I think pghero is already in an iframe in the admin, and then this partial is also loading bootstrap and vuejs 🤮
I don't have the FE skills to do this cleaner, so open to suggestions. Maybe it doesn't matter if it's ugly 🤷
There was a problem hiding this comment.
Actually, I don't think our admin uses bootstrap haha. So at least it's not double loaded.
I feel like this is fine, if there is no other simple way to imbed pev2 without vue then this is probably the best way to do it without spending ages on it.
Embeds the PEV2 plan viewer into the Explain -> Visualize page.
The previous instructions with a link to PEV version 1 are still below the new viewer in a collapsed
<summary>block.