skip slsa e2e tests by default

we shouldnt test an experimental feature by default Signed-off-by: Bohan Chen <[email protected]>
buildpacks-community · Jan 25, 2024 · c32283a · c32283a
1 parent 82b764b
commit c32283a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -409,7 +409,7 @@ jobs:
         export GIT_BASIC_PASSWORD="${{ secrets.E2E_PRIVATE_REPO_PASSWORD }}"
         export GIT_SSH_PRIVATE_KEY="${{ secrets.E2E_PRIVATE_REPO_PRIVATE_KEY }}"
 
-        make e2e
+        E2E_SLSA="true" make e2e
         kapp delete -a kpack -y
 
     - name: Run tests with Istio

diff --git a/test/slsa_test.go b/test/slsa_test.go
@@ -12,6 +12,7 @@ import (
 	"encoding/json"
 	"encoding/pem"
 	"fmt"
+	"os"
 	"strings"
 	"testing"
 
@@ -41,9 +42,10 @@ import (
 )
 
 func TestSlsa(t *testing.T) {
-	t.Cleanup(func() {
-		fmt.Println("TestSlsa cleanup")
-	})
+	if testSlsa, _ := os.LookupEnv("E2E_SLSA"); testSlsa != "true" {
+		t.Skip("E2E_SLSA not set, skipping")
+	}
+
 	spec.Run(t, "SLSA", testSlsaBuild)
 }