Document builder property available in project descriptor #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mars Hall <[email protected]>
edmorley
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Thank you for this!
I don't suppose you'd mind also documenting the builder option on:
https://buildpacks.io/docs/reference/config/project-descriptor/
(It seems https://buildpacks.io/docs/reference/config/project-descriptor/ is missing a few things from https://github.com/buildpacks/spec/blob/main/extensions/project-descriptor.md)
Signed-off-by: Mars Hall <[email protected]>
|
Done @edmorley 🙌 |
Signed-off-by: Mars Hall <[email protected]>
AidanDelaney
approved these changes
Aug 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Document builder property available in project descriptor Signed-off-by: Mars Hall <[email protected]> * Define io.buildpacks.builder in Config Reference Signed-off-by: Mars Hall <[email protected]> * Correct the example toml Signed-off-by: Mars Hall <[email protected]> --------- Signed-off-by: Mars Hall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some Google Cloud docs about this, but they seem to be non-standard. This change adds a section explaining the standard way to set the builder.