Use the Image Digest to save it in a Registry #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OCI spec defines an Image Index concept to handle multiple manifests in an OCI image. This adds the interface for Image Index. Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
remote.Image uses descriptor to get the image. Getting the descriptor first and deriving the image from the descriptor is efficient instead of getting the descriptor twice. Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
AppendManifest and AnnotateManifest functions are now refactored to be ImageIndex functions. Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Platform information is OPTIONAL if the target is plaform independent. See specification for more info: https://github.com/opencontainers/image-spec/blob/0b40f0f367c396cc5a7d6a2e8c8842271d3d3844/image-index.md#image-index-property-descriptions Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
When creating a new local index, if the the referenced images are not in the same registry as the registry we intend to push the index we copy the images to the same registry as the index. NOTE: In future we plan to store the image reference names locally and only copy the images when push the index to registry. Signed-off-by: Husni Faiz <[email protected]>
This fixes the following errors, - use strings.ReplaceAll method instead of strings.Replace - `infromation` is a misspelling of `information` - var-naming: don't use underscores in Go names - unnecessary conversion (unconvert) - ineffectual assignment to err - unnecessary trailing newline - unnecessary leading newline Signed-off-by: Husni Faiz <[email protected]>
Signed-off-by: Husni Faiz <[email protected]>
…ith the implementation of the multi-arch RFC when we want to create an Image Index in the registry Signed-off-by: Juan Bustamante <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 58.29% 55.75% -2.53%
==========================================
Files 32 38 +6
Lines 3694 3778 +84
==========================================
- Hits 2153 2106 -47
- Misses 1184 1349 +165
+ Partials 357 323 -34 |
2 tasks
|
We don't need this change anymore, I updated our pack manifest commands PR to use the latest version of the imgutil code (after we merged the image index logic) and we don't need this hack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was done to replace the image name with the digest when saving it in a registry, the idea is to use it when we are creating multi-arch images and we need to save each intermediate image before creating the
Image Index.The work is based on Husni's PR, because I need his logic to create the
Image Indexbut my change is actually only in this commitThis is a DRAFT! I am not sure if this is the best way to do it, I just needed a way to solve my problem and develop the PoC