Fix: archive/tar: write too long error when using Docker Desktop containerd backend
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainerd backend Fixes buildpacks/pack#2174 This is somewhat of a band-aid solution and degrades performance because we have to read the uncompressed layer bits to get the uncompressed layer size for layers that we `docker save` out of the daemon (re-used layers and all the base layers). The better longer-term fix will be to send OCI-layout formatted tars when we have all the layers available (when using containerd as the backing store, this will always be true). Signed-off-by: Natalie Arellano <[email protected]>
| if err != nil { | ||
| return err | ||
| } | ||
| return i.AddLayerWithHistory(layer, emptyHistory) | ||
| } | ||
|
|
||
| func calculateChecksum(path string) (string, error) { |
There was a problem hiding this comment.
This function relies on the daemon always outputting uncompressed layers, which is no longer true
| } | ||
| if fileSize == compressedSize { | ||
| // the layer is compressed, we don't know the uncompressed size | ||
| uncompressedSize = -1 |
There was a problem hiding this comment.
This is the real fix
| @@ -288,11 +289,13 @@ func (s *Store) getLayerSize(layer v1.Layer) (int64, error) { | |||
| return 0, err | |||
| } | |||
| knownLayer, layerFound := s.onDiskLayersByDiffID[diffID] | |||
| if layerFound { | |||
| if layerFound && knownLayer.uncompressedSize != -1 { | |||
There was a problem hiding this comment.
This is the real fix
jjbustamante
approved these changes
Jun 3, 2024
Yeah, we need it. And, containerd should be enabled as the backing storage. It's a bit of a mess. |
jabrown85
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (in part) buildpacks/pack#2174
This is somewhat of a band-aid solution and degrades performance because we have to read the uncompressed layer bits to get the uncompressed layer size for layers that we
docker saveout of the daemon (re-used layers and all the base layers).The better longer-term fix will be to send OCI-layout formatted tars when we have all the layers available (when using containerd as the backing store, this will always be true).