Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lifecycle/cmd/restorer to move logic out of main and into phase package #1338

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Apr 12, 2024

Summary

This is still somewhat a WIP - I need to update the code comments and also add unit tests, as that's a major advantage of this refactor.

Release notes


Related

Resolves #___


Context

@natalieparellano natalieparellano changed the base branch from main to bump-imgutil April 12, 2024 20:15
Base automatically changed from bump-imgutil to main April 16, 2024 16:58
return metadata != nil && metadata.OS != ""
}

func (r *Restorer) updateAnalyzedMD() error {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func (r *Restorer) updateAnalyzedMD() error {
func (r *Restorer) updateAnalyzedMDRunImageTarget() error {

Signed-off-by: Natalie Arellano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move logic out of cmd/restorer
1 participant