-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README for 0.20.x #1401
Update README for 0.20.x #1401
Conversation
Signed-off-by: Natalie Arellano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!
Out of curiosity, do you know when we might want the next round of platform/buildpack API deprecations to take place? (Similar to https://github.com/buildpacks/rfcs/blob/main/text/0110-deprecate-apis.md)
Oh gosh, I do not know. I suppose it would start with an RFC similar to https://github.com/buildpacks/rfcs/blob/main/text/0110-deprecate-apis.md Sadly, I think some folks have still not upgraded from the pre-0.7 APIs 😭 Maybe we should do a survey? On the platform side, it would be nice to remove at least 0.7 and 0.8. This gets us over the breaking change released in 0.9: "Legacy BOM information is removed from the On the buildpack side, we could aspire to remove 0.7 and 0.8. This gets us over shell removal, released in 0.9, but I imagine that might be a heavy lift for some folks and we'd want a long window with deprecation warnings, etc. https://github.com/buildpacks/profile will help, but we'll probably want to implement https://github.com/buildpacks/rfcs/blob/main/text/0101-system-buildpacks-in-builder.md to make it easier for folks to include this helper. We could at least start the RFC to get the conversation going. Thoughts here are very welcome :) |
That's a great summary, thank you :-) So the main reason I asked was that I'm concerned we'll run into a situation in the future where lots more buildpacks have been created (either for Heroku, or generally) that use old Buildpack API versions, that then becomes a nightmare to migrate away from. For example, Heroku's builder images currently use the latest version of lifecycle, which we can quite easily update since in general there haven't been many breaking changes, and our builder images are still "in preview". However, once CNBs on Heroku reaches General Availability, upgrading to new future lifecycle versions that drop support for older Buildpack APIs (thereby breaking compatibility with third-party buildpacks end-users might be using) will be much more painful. To reduce the impact of this, we could:
Though items like (4) will take much more effort/time, which is why I was thinking (1) might be a good place to start :-) |
@edmorley I like that - maybe something (perhaps an info message, less noisy than a warning) that's like "FYI - your buildpack version is superseded. Check out https://buildpacks.io/docs/for-buildpack-authors/how-to/migrate/" For posterity, I remembered that https://github.com/buildpacks/profile is needed in order for us to remove shell support in the launcher. It isn't directly tied to buildpacks upgrading or not upgrading. |
Summary
Release notes
Related
Resolves #___
Context