Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCP credential provider #887

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add GCP credential provider #887

wants to merge 1 commit into from
+148 −32

Commits on Jul 26, 2022

  1. Add GCP credential provider 

    This was originally added in #540 but removed in #560. The GCP credential provider from
github.com/vdemeester/k8s-pkg-credentialprovider/gcp would loop forever when the metadata
server could not be reached (see kubernetes/kubernetes#86245).

However it appears that the GGCR re-implementation in github.com/google/go-containerregistry/pkg/v1/google
doesn't suffer from this problem, and therefore support for GCP might be safe to add back.

Signed-off-by: Natalie Arellano <[email protected]>
    @natalieparellano
    natalieparellano committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    3869725 View commit details
    Browse the repository at this point in the history