Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heroku/builder:24 as a trusted + suggested builder #2178

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Jun 5, 2024

Summary

We have just completed our new heroku/builder:24 builder, which is based upon Ubuntu 24.04 and is also our first multi-architecture (AMD64+ARM64) builder.

As such, I have:

  • Added heroku/builder:24 as a trusted+suggested builder
  • Changed the existing heroku/builder:22 builder entry so that it is now just trusted, and not also suggested (since we want to encourage users to use the newer builder, especially since it's now multi-arch).
  • Re-synced the builder description metadata here with what's in our builder.toml configs. (The descriptions in this repo are what gets used in offline mode, when Pack CLI can't pull the latest image description from the image labels on the registry.)

See:
heroku/cnb-builder-images#534
https://github.com/heroku/cnb-builder-images/blob/main/builder-20/builder.toml
https://github.com/heroku/cnb-builder-images/blob/main/builder-22/builder.toml
https://github.com/heroku/cnb-builder-images/blob/main/builder-24/builder.toml

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

We have just completed our new `heroku/builder:24` builder,
which is based upon Ubuntu 24.04 and is also our first
multi-architecture (AMD64+ARM64) builder.

As such, I have:
- Added `heroku/builder:24` as a trusted+suggested builder
- Changed the existing `heroku/builder:22` builder entry so
  that it is now just trusted, and not also suggested (since we
  want to encourage users to use the newer builder, especially
  since it's now multi-arch).
- Re-synced the builder description metadata here with what's in
  our `builder.toml` configs. (The descriptions in this repo are
  what gets used in offline mode, when Pack CLI can't pull the
  latest image description from the image labels on the registry.)

See:
heroku/cnb-builder-images#534
https://github.com/heroku/cnb-builder-images/blob/main/builder-20/builder.toml
https://github.com/heroku/cnb-builder-images/blob/main/builder-22/builder.toml
https://github.com/heroku/cnb-builder-images/blob/main/builder-24/builder.toml

Signed-off-by: Ed Morley <[email protected]>
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Jun 5, 2024
@github-actions github-actions bot added this to the 0.35.0 milestone Jun 5, 2024
@edmorley edmorley marked this pull request as ready for review June 5, 2024 10:44
@edmorley edmorley requested review from a team as code owners June 5, 2024 10:44
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natalieparellano
Copy link
Member

Manually verified the DCO

@natalieparellano natalieparellano merged commit cffbe0b into buildpacks:main Jun 5, 2024
15 checks passed
@edmorley edmorley deleted the heroku-builder-24 branch June 5, 2024 14:53
@edmorley
Copy link
Contributor Author

edmorley commented Jun 5, 2024

Thank you for the review/merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants