Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Google builder in the list of known builders. #2203

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

hhiroshell
Copy link
Contributor

Summary

This PR updates the version of the Google builder in the KnownBuilders addressing #2199

In this PR, I have removed gcr.io/buildpacks/builder:v1 from both Trusted and Suggested. If there are criteria for being Trusted or Suggested that require keeping v1, please let me know. I will be happy to make the necessary adjustments.

Output

Before

  • pack builder suggest
$ pack builder suggest
Suggested builders:
        Google:                gcr.io/buildpacks/builder:v1                            GCP Builder for all runtimes
        Heroku:                heroku/builder:22                                       Heroku-22 (Ubuntu 22.04) base image with buildpacks for Go, Java, Node.js, PHP, Python, Ruby & Scala
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-base                     Small base image with buildpacks for Java, Node.js, Golang, .NET Core, Python & Ruby
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-buildpackless-static     Static base image (jammy build image, distroless run image) suitable for static binaries like Go or Rust
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-full                     Larger base image with buildpacks for Java, Node.js, Golang, .NET Core, Python, Ruby, & PHP
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-tiny                     Tiny base image (jammy build image, distroless run image) with buildpacks for Golang & Java
  • pack config trusted-builders list
$ pack config trusted-builders list
Trusted Builders:
  gcr.io/buildpacks/builder:v1
  heroku/builder:20
  heroku/builder:22
  paketobuildpacks/builder-jammy-base
  paketobuildpacks/builder-jammy-buildpackless-static
  paketobuildpacks/builder-jammy-full
  paketobuildpacks/builder-jammy-tiny

After

  • pack builder suggest
$ pack builder suggest
Suggested builders:
        Google:                gcr.io/buildpacks/builder:google-22                     GCP Builder for all runtimes
        Heroku:                heroku/builder:24                                       Ubuntu 24.04 AMD64+ARM64 base image with buildpacks for Go, Java, Node.js, PHP, Python, Ruby & Scala.
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-base                     Small base image with buildpacks for Java, Node.js, Golang, .NET Core, Python & Ruby
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-buildpackless-static     Static base image (jammy build image, distroless run image) suitable for static binaries like Go or Rust
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-full                     Larger base image with buildpacks for Java, Node.js, Golang, .NET Core, Python, Ruby, & PHP
        Paketo Buildpacks:     paketobuildpacks/builder-jammy-tiny                     Tiny base image (jammy build image, distroless run image) with buildpacks for Golang & Java
  • pack config trusted-builders list
$ pack config trusted-builders list
Trusted Builders:
  gcr.io/buildpacks/builder:google-22
  heroku/builder:20
  heroku/builder:22
  heroku/builder:24
  paketobuildpacks/builder-jammy-base
  paketobuildpacks/builder-jammy-buildpackless-static
  paketobuildpacks/builder-jammy-full
  paketobuildpacks/builder-jammy-tiny

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #2199

@hhiroshell hhiroshell requested review from a team as code owners July 4, 2024 10:44
@github-actions github-actions bot added this to the 0.35.0 milestone Jul 4, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 4, 2024
hhiroshell and others added 3 commits July 4, 2024 20:13
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Jul 4, 2024
@jjbustamante
Copy link
Member

jjbustamante commented Jul 7, 2024

Do we want to keep older builders as trusted but not suggested as we do with Heroku?

@natalieparellano , @edmorley

I think the answer is no, but just wanted to double check, otherwise this one looks good to me

@edmorley
Copy link
Contributor

edmorley commented Jul 7, 2024

Do we want to keep older builders as trusted but not suggested as we do with Heroku?

For the Heroku builders, we've used the following methodology:

  • remove any builders that are EOL (eg those based on Ubuntu 18.04)
  • have all other active Heroku builders be trusted
  • have only the most recent Heroku builder (which is currently the one based on Ubuntu 24.04) be suggested

Given that the gcr.io/buildpacks/builder:v1 builder is based on Ubuntu 18.04 and so EOL, I think it makes sense to remove it entirely from trusted builders.

@natalieparellano natalieparellano merged commit 0b0614b into buildpacks:main Jul 9, 2024
16 checks passed
@hhiroshell hhiroshell deleted the fix-pack-2199 branch July 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Google's suggested builder
4 participants