Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #304

Merged

Conversation

enrichman
Copy link
Contributor

A link to the lifecycle descriptor RFC was using an old branch.

Fixed.

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

@natalieparellano
Copy link
Member

Aye, I think we need to fix the DCO 😞 https://github.com/buildpacks/rfcs/pull/304/checks?check_run_id=28521018372

@enrichman enrichman force-pushed the fix-pack-publish-buildpack-link branch 3 times, most recently from c4c31dd to 1da2628 Compare August 8, 2024 15:08
Signed-off-by: Enrico Candino <[email protected]>
@enrichman enrichman force-pushed the fix-pack-publish-buildpack-link branch from 832de83 to 9b15d01 Compare August 8, 2024 15:13
@enrichman
Copy link
Contributor Author

Thanks @natalieparellano, not sure which was the problem but I had to resync everything. Probably the DCO was added later and I had very old commits in my fork without the Sign-off-by!

@natalieparellano natalieparellano merged commit 393e370 into buildpacks:main Aug 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants