Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for pack detect #308

Merged
merged 5 commits into from
Aug 22, 2024
Merged

RFC for pack detect #308

merged 5 commits into from
Aug 22, 2024

Conversation

rashadism
Copy link
Contributor

A basic implementation on pack detect.
Looking forward on getting feedback and improving on this and coming up with the best version of this, and implenenting this.

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off @rashadism! I would love to see this happen :)

@rashadism
Copy link
Contributor Author

Thank you @natalieparellano , will update on the stuff you pointed out.

@natalieparellano natalieparellano changed the title Initial draft, up for feedback RFC for pack detect Mar 27, 2024
@rashadism rashadism mentioned this pull request Apr 18, 2024
2 tasks
@rashadism
Copy link
Contributor Author

I opened a corresponding draft PR . @natalieparellano can u have a look

@natalieparellano
Copy link
Member

@jjbustamante is going to steward this one :)

@rashadism
Copy link
Contributor Author

@jjbustamante is going to steward this one :)

nice, looking forward to it (:

text/0000-my-feature.md Outdated Show resolved Hide resolved
text/0000-my-feature.md Outdated Show resolved Hide resolved
text/0000-my-feature.md Outdated Show resolved Hide resolved
text/0000-my-feature.md Outdated Show resolved Hide resolved
@natalieparellano
Copy link
Member

I think this one might be ready for another round of reviews.

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we need to fix DCO :)

@natalieparellano
Copy link
Member

Maintainers, please review! I'll move this one to "voting" on Thursday.

rashadism and others added 5 commits August 15, 2024 12:05
Signed-off-by: Rashad Sirajudeen <[email protected]>
Co-authored-by: Daniel Mikusa <[email protected]>
Signed-off-by: Rashad Sirajudeen <[email protected]>
Signed-off-by: Rashad Sirajudeen <[email protected]>
Signed-off-by: Rashad Sirajudeen <[email protected]>
@jabrown85
Copy link
Contributor

@rashadism can I get your acceptance on the DCO? I can mark it passed and merge if you'll reply back with a 👍

@jabrown85 jabrown85 merged commit c768bdf into buildpacks:main Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period scope/team RFC scoped to a sub-team as opposed to the entire project. status/voting team/platform type/rfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants