Extract check out of nested parens

bullet-train-co · Dec 14, 2023 · 7aad146 · 7aad146
1 parent d61f94d
commit 7aad146
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/...authorize_resource/app/controllers/concerns/bullet_train/loads_and_authorizes_resource.rb b/...authorize_resource/app/controllers/concerns/bullet_train/loads_and_authorizes_resource.rb
@@ -79,12 +79,8 @@ def account_load_and_authorize_resource(model, options, old_options = {})
 
       through_as_symbols.each do |through_as_symbol|
         # reflect on the belongs_to association of the child model to figure out the class names of the parents.
-        unless (
-                 association =
-                   model_class_name.constantize.reflect_on_association(
-                     through_as_symbol
-                   )
-               )
+        association = model_class_name.constantize.reflect_on_association(through_as_symbol)
+        unless association
           raise "Oh no, it looks like your call to 'account_load_and_authorize_resource' is broken. Tried to reflect on the `#{through_as_symbol}` association of #{model_class_name}, but didn't find one."
         end