Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor loads and authorize resource part 1 #717

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Refactor loads and authorize resource part 1 #717

merged 3 commits into from
Dec 14, 2023

Conversation

kaspth
Copy link
Contributor

@kaspth kaspth commented Dec 14, 2023 •
edited by jagthedrummer
Loading

  • Makes some exception messages less wordy
  • Simplifies the way we turn a single argument into an array
  • Simplification of a conditional

From #525

@kaspth kaspth requested a review from jagthedrummer December 14, 2023 17:59
jagthedrummer
jagthedrummer approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jagthedrummer jagthedrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking these out, @kaspth! Much easier to see exactly what's going on.

@jagthedrummer
Copy link
Contributor

The CI failures are caused by an update to Chrome, which I fixed in the starter repo here: bullet-train-co/bullet_train#1243

I'll go ahead and merge these if the only failure is that one.

@jagthedrummer jagthedrummer merged commit 8a46a56 into main Dec 14, 2023
30 checks passed
@jagthedrummer jagthedrummer deleted the refactor-loads-and-authorize-resource-part-1 branch December 14, 2023 18:32
@jagthedrummer jagthedrummer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagthedrummer jagthedrummer jagthedrummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspth @jagthedrummer