Refactor loads and authorize resource part 5 #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagthedrummer
force-pushed
the
refactor-loads-and-authorize-resource-part-4
branch
from
5d9c39d to
ff15506
Compare
Base automatically changed from
refactor-loads-and-authorize-resource-part-4
to
main
December 14, 2023 19:18
I'm grouping it with the exception so it's easier to see why `through_as_symbols.first` works.
`eval` just evaluates in the same scope, so if we can assign instance variables in there, we can both get and assign them without eval.
jagthedrummer
force-pushed
the
refactor-loads-and-authorize-resource-part-5
branch
from
312c11e to
dd916df
Compare
...nd_authorize_resource/app/controllers/concerns/bullet_train/loads_and_authorizes_resource.rb
Outdated
Show resolved
Hide resolved
…/concerns/bullet_train/loads_and_authorizes_resource.rb Co-authored-by: Jeremy Green <[email protected]>
jagthedrummer
deleted the
refactor-loads-and-authorize-resource-part-5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
evalwith direct setting of variables and/orinstance_variable_setas appropriate.From #525
Also closes #525.