Bullet Train Update: 1.7.10 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Getting started on splitting up bin/configure * a little polish * checks for postgres and redis * more splitting of bin/configure * a little more progress * Commit changes after updating configs * Add some scripts for adding 'deploy to __' buttons, also some clean up * Should add the deploy buttons after we've set up a repo * A little more polish * some polish * Fix the heroku button text * dang linter * robustify postgres detection * Make it more clear wich subscript we're currently running * handle the case where redis-cli isn't installed * dang linter * A little polish * Replace the old script with the new one * Fix some comments
* Fix Heroku deploys for yarn 4 Heroku recommends having the `heroku/nodejs` buildpack before `heroku/ruby`. So I updated `app.json` to to that. But the `heroku/nodejs` buildpack tries to run `yarn build` automatically. But our build steps shell out to bundler, and since `heroku/ruby` comes after `heroku/nodjs` bundler isn't yet available. Adding a `heroku-postbuild` script makes it so that Heroku runs _that_ script instead of running the normal `build` script. Which prevents the lack of ruby/bundler from being a problem during the setup phase for the `heroku/nodejs` buildpack. Then to ensure that `yarn build` is run, I've added that to the end of the `release` phase in `Procfile`. * Don't need to manually call 'yarn build' * Update the message about heroku-postbuild
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: jagthedrummer <[email protected]>
# Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the Bullet Train Starter Repo to version
1.7.10Please note: You should thorougly review this PR.
🎉 There are no conflicts detected in this PR!