Bullet Train Update: 1.7.15 #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does a few things to make the process of setting up an app on Heroku better and cheaper. 1. It adds a buildpack for `jemalloc` and sets the `JEMALLOC_ENABLED` ENV var. Fixes: bullet-train-co/bullet_train#1524 2. Makes the initial setup cheaper by using smaller dynos and the entry level for a number of addons. Fixes: bullet-train-co/bullet_train#1127 3. Removes the Sentry addon. This was redundant since Honeybadger was already included, and Sentry isn't supported in review apps on Heroku, so having it in `app.json` prevents the use of review apps entirely which is frustrating. Fixes: bullet-train-co/bullet_train#1521 4. Sets `RAILS_MAX_THREADS` and `WEB_CONCURRENCY` to match the values suggested by heroku here: https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server#recommended-default-puma-process-and-thread-configuration Fixes: bullet-train-co/bullet_train#1523
Co-authored-by: jagthedrummer <[email protected]>
* Run the PartialTest on a dedicated CI node Previously every node that ran _any_ super scaffolding test would also run the super scaffolding test for `PartialTest`. This PR makes it so that we run that test on a dedicated node, and all the other nodes won't run it. * Need to keep that * consolidate some tests onto the same CI node
Co-authored-by: jagthedrummer <[email protected]>
Co-authored-by: jagthedrummer <[email protected]>
* Bump setup-node to v4 * Update actions/cache to v4
Some users are reporting crashes on MacOS when first trying to access the database. There's an issue open on `ruby-pg` that describes this temporary workaround. ged/ruby-pg#538 Hopefully fixes: bullet-train-co/bullet_train#1379
* wip * making progress * more refactoring * tweak * Move some stuff out of bin/configure and into bin/setup * linter
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: jagthedrummer <[email protected]>
# Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the Bullet Train Starter Repo to version
1.7.15Please note: You should thorougly review this PR.
🎉 There are no conflicts detected in this PR!