Updating bullet train to 1.4.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jagthedrummer <[email protected]>
…(#635) * add Addresses::Country and Addresses::Region * add Address model, factory * add snail gem * tangible_thing_test: check address fields refresh on country change * remove snail gem * add Addresses::Continent and Addresses::Subcontinent * tests: fix find_stimulus_controller_for_label to permit multiple controllers * fix a merge conflict that snuck through * make the linter happy --------- Co-authored-by: Jeremy Green <[email protected]>
Co-authored-by: jagthedrummer <[email protected]>
* Add `ruby-vips` in the `:development, :test` group This (mostly) fixes the problem reported in bullet-train-co/bullet_train-core#464 However, due to bullet-train-co/bullet_train-core#498 we don't currently try to show a user profile photo if we're using ActiveStorage instead of Cloudinary. Here's some context about why we need to add this directly to the `Gemfile`. libvips/ruby-vips#155 (comment) * Try it here
Co-authored-by: jagthedrummer <[email protected]>
Co-authored-by: jagthedrummer <[email protected]>
With parallelism set to 16 we spend about 75-80% of the time in any given job doing setup, and only 20-25% of the time running tests. Decreasing parallelism will give us a better ratio, and shouldn't increase testing time all that much.
Co-authored-by: jagthedrummer <[email protected]>
* Explicitly set the expected verison of BulletTrain gems * Add the unlisted core gems to the `Gemfile` * Explicitly set the verison in package.json * liner * 1.3.24 * Update bump-core to accept a version number and to explicitly use that value * Update the workflow action to accept a version number * a little clean up * Pass the version number down to bin/bump-core * Add Gemfile and package.json to the PR * 1.3.25
Co-authored-by: jagthedrummer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.