Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ConditionBuilder): Added automation attributes to boolean condition selector #1616

Closed
wants to merge 1 commit into from

Conversation

davidkbh
Copy link
Collaborator

@davidkbh davidkbh commented Oct 4, 2024

Description

It was difficult to reliably grab Yes/No/True/False values from the boolean condition selector when writing automation tests; in the DOM, the only indicator was the user label.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 9d82f40):

https://novo-elements--pr1616-f-condition-bool-aut-ktznjm26.web.app

(expires Mon, 14 Oct 2024 14:27:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@davidkbh davidkbh closed this Oct 7, 2024
@davidkbh davidkbh deleted the f/condition-bool-autoids branch October 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant