Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User-Agent header with sdk version #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add User-Agent header with sdk version #27

wants to merge 2 commits into from

Conversation

walison17
Copy link
Contributor

No description provided.

@walison17 walison17 requested a review from avelino February 25, 2025 17:31
avelino
avelino approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

it was not clear what problem you want to solve?
leave in the barte servers logs that the request is from the python SDK?

@walison17
Copy link
Contributor Author

LGTM

it was not clear what problem you want to solve? leave in the barte servers logs that the request is from the python SDK?

Exactly, it is also considered a best practice to customize this header in SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelino avelino avelino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walison17 @avelino