Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/navbar #16

Closed
wants to merge 3 commits into from
Closed

Feature/navbar #16

wants to merge 3 commits into from

Conversation

eracksonsouza
Copy link
Collaborator

Pull Request Details

Updates have been added to tailwind in package.json, and created the navbar file, and together the o component style

Motivation and context

Add style to project navbar

How is it being tested?

In no way

Types of modifications

  • Dependency update / refactoring / documentation
  • Bug fix (No modifications that impact backwards compatibility)
  • New functionality (adaptive or evolutionary) (No modifications that impact backwards compatibility)
  • Compatibility break (Correction or new functionality that impacts backwards compatibility)

Check list

  • My code complies with the project standard.
  • My modifications require updating the documentation.
  • I modified the documentation according to the changes made.
  • I added tests to cover my modifications.
  • All new and old tests are passing.


<template>
<header class="layout container min-w-full">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a header tag again, it should not be removed

<nav
class="bg-var secondaryDarker border-gray-200 dark:bg-gray-900 dark:border-gray-700"
>
<div
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div is a shadcn component. See in their docs how to install a component, and use this

@bush1D3v bush1D3v closed this Sep 16, 2024
@bush1D3v bush1D3v deleted the feature/navbar branch September 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants