Extend timeouts #181
Open
Extend timeouts #181
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphines
reviewed
Apr 23, 2019
| @@ -185,8 +185,8 @@ func (t *upstreamTransport) getTransport() *http.Transport { | |||
| t.transport = &http.Transport{ | |||
| Proxy: http.ProxyFromEnvironment, | |||
| DialContext: (&net.Dialer{ | |||
| Timeout: 30 * time.Second, | |||
| KeepAlive: 30 * time.Second, | |||
| Timeout: 300 * time.Second, | |||
There was a problem hiding this comment.
We should figure out a way to make this configurable. A default of 300 seconds (much like 30 seconds) is unlikely to be sufficient for everyone's needs.
jphines
reviewed
Apr 23, 2019
| @@ -216,6 +216,7 @@ func NewReverseProxy(to *url.URL, config *UpstreamConfig) *httputil.ReverseProxy | |||
| req.Host = to.Host | |||
| } | |||
| } | |||
| proxy.FlushInterval = 100 * time.Millisecond | |||
There was a problem hiding this comment.
I don't think we should supply this default since this is configurable per upstream.
There was a problem hiding this comment.
That can be dropped, yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using SSO proxy to sit in the middle of another auth component that blocks waiting for authentication to complete. We need a long timeout to allow the user to finish the authentication flow that SSO is mediating. The timeout needs to at least get us past p99 time-to-complete-authentication and 5 minutes seems to be approximately the sweet spot.