Skip to content

Commit

Permalink
Use a nicer list reporter locally (#356)
Browse files Browse the repository at this point in the history
This addresses the complaint from
#348 (comment)
. I didn't realize that the default is `'list'` locally, I added
`'line'` reporter since I've seen that being used in a couple of other
projects. I totally agree that `'list'` is quite nice and I prefer it to
`'line'` - especially if we consider smaller test suites.

⚠️ `@replayio/playwright` still spits out a bunch of junk into the
stdout. That makes the current output very cluttered - even with this
improvement. This is going to be addressed with PRO-315
  • Loading branch information
Andarist authored May 10, 2024
1 parent 8f63b71 commit e786040
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 16 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"devDependencies": {
"@babel/preset-typescript": "^7.22.5",
"@playwright/test": "^1.37.0",
"@playwright/test": "^1.44.0",
"@replayio/playwright": "3.0.0-alpha.9",
"@types/jest": "^29.5.3",
"@types/node": "^18.17.5",
Expand Down
6 changes: 4 additions & 2 deletions packages/react-resizable-panels-website/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ const config: PlaywrightTestConfig = {
apiKey: process.env.REPLAY_API_KEY,
upload: true,
})
: ["line"],
],
: undefined,
// replicating Playwright's defaults
process.env.CI ? (["dot"] as const) : (["list"] as const),
].filter((v): v is NonNullable<typeof v> => !!v),
use: {
browserName: "chromium",
headless: true,
Expand Down
33 changes: 20 additions & 13 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e786040

Please sign in to comment.