Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Cursor icon behavior in nested panels (#378) #390

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix: Cursor icon behavior in nested panels (#378) #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-resizable-panels/src/PanelGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ function PanelGroupWithForwardedRef({
if (prevDeltaRef.current != delta) {
prevDeltaRef.current = delta;

if (!layoutChanged) {
if (!layoutChanged && delta !== 0) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would this impact the else condition below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand if delta is 0 it always means that the mouse is on top of the resize handle, meaning it can't be outside of the resize limits, so constraint violations are set to none.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense.

// If the pointer has moved too far to resize the panel any further, note this so we can update the cursor.
// This mimics VS Code behavior.
if (isHorizontal) {
Expand Down
Loading