Before stack comparison, check if target element is in document #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Yeah no worries. I appreciate it. It's late where I'm at but I'll leave this open until I have time to look at it a little closer. If it doesn't seem like it will cause any negative impact, I don't mind landing it. |
|
Any updates? 👀 |
|
Truthfully I have not thought about it much yet. Week days are busy (job) and this is not a huge priority for me. |
|
I don't think it should break or affect any pre-existing apps so I think it's safe to make. Appreciate your patience. |
|
This change has been released in [email protected] ❤️ → ☕ givebrian.coffee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409
Don't feel pressured to merge, but I figured that the solution is fairly simple so I implemented it myself.