Merge pull request #45 from asimlqt/striptags

Replaced html to text with standard strip_tags function
byng-systems · Jul 10, 2018 · e9d6a28 · e9d6a28
2 parents ac88e18 + ed43896
commit e9d6a28
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 21 deletions.
diff --git a/lib/Byng/Pimcore/Elasticsearch/Processor/Element/ElementProcessor.php b/lib/Byng/Pimcore/Elasticsearch/Processor/Element/ElementProcessor.php
@@ -14,7 +14,6 @@
 namespace Byng\Pimcore\Elasticsearch\Processor\Element;
 
 use Byng\Pimcore\Elasticsearch\Processor\ProcessorException;
-use NF\HtmlToText;
 use Pimcore\Model\Document\Tag;
 
 /**
@@ -25,22 +24,6 @@
  */
 final class ElementProcessor
 {
-    /**
-     * @var HtmlToText
-     */
-    private $htmlToTextFilter;
-
-
-    /**
-     * Constructor
-     *
-     * @param HtmlToText $htmlToTextFilter
-     */
-    public function __construct(HtmlToText $htmlToTextFilter)
-    {
-        $this->htmlToTextFilter = $htmlToTextFilter;
-    }
-
     /**
      * Process a generic element
      *
@@ -60,7 +43,6 @@ public function processElement(Tag $tag)
             );
         }
 
-        // This needs to be handled much more elegantly than with the error suppression operator
-        return @$this->htmlToTextFilter->convert($elementData);
+        return strip_tags($elementData);
     }
 }
diff --git a/lib/Byng/Pimcore/Elasticsearch/Processor/Page/PageProcessorFactory.php b/lib/Byng/Pimcore/Elasticsearch/Processor/Page/PageProcessorFactory.php
@@ -18,7 +18,6 @@
 use Byng\Pimcore\Elasticsearch\Processor\Element\DateElementProcessor;
 use Byng\Pimcore\Elasticsearch\Processor\Element\ElementProcessor;
 use Byng\Pimcore\Elasticsearch\Processor\Element\SelectElementProcessor;
-use NF\HtmlToText;
 
 /**
  * PageProcessor Factory
@@ -37,7 +36,7 @@ final class PageProcessorFactory
      */
     public function build(FilterInterface $filter = null)
     {
-        $elementProcessor = new ElementProcessor(new HtmlToText());
+        $elementProcessor = new ElementProcessor();
 
         return new PageProcessor(
             $elementProcessor,