fix: zero coercion timeout removal bug (#72)

bytecodealliance · Jun 22, 2024 · 3e5585e · 3e5585e
1 parent 4cd78b6
commit 3e5585e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/builtins/web/timers.cpp b/builtins/web/timers.cpp
@@ -114,7 +114,7 @@ class TimerTask final : public api::AsyncTask {
 };
 
 std::map<int32_t, PollableHandle> TimerTask::timer_ids_ = {};
-int32_t TimerTask::next_timer_id = 0;
+int32_t TimerTask::next_timer_id = 1;
 
 namespace builtins::web::timers {
 

diff --git a/tests/integration/timers/timers.js b/tests/integration/timers/timers.js
@@ -2,6 +2,16 @@ import { serveTest } from "../test-server.js";
 import { assert, strictEqual, throws, deepStrictEqual, AssertionError } from "../assert.js";
 
 export const handler = serveTest(async (t) => {
+  await t.asyncTest("clearTimeout invalid", (resolve, reject) => {
+    // cleartimeout can be called with arbitrary stuff
+    clearTimeout('blah');
+
+    const dontDeleteTimeout = setTimeout(resolve, 100);
+
+    // null converts to zero, which must not delete a real timer
+    clearTimeout(null);
+  });
+
   await t.asyncTest("setTimeout-order", (resolve, reject) => {
     let first = false;
     setTimeout(() => {