Update adapter to wasmtime 14.0.3 #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian H <[email protected]>
|
For my understand, as I am now generally bumping the adapter version only for major wasmtime releases and I don't see any wit changes from 14.0.0, is bumping the adapter necessary? |
|
I just confirmed, there were no changes to the adapter source code, or the wit files, between 14.0.0 and 14.0.3. I am curious why the hash changed between those releases, did rustc change as well? |
|
The hash here is a wasmtime commit and not a hash of the adapter module itself, so I would expect differences between wasmtime versions. |
|
@peterhuene sorry for the noise! Thanks for confirming the process! |
|
oh, right, I forgot we put the commit in there. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.