Skip to content

Commit

Permalink
targets must match package_id
Browse files Browse the repository at this point in the history
  • Loading branch information
jsturtevant committed Jun 14, 2024
1 parent 5c1986a commit b64e103
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Restore dependencies
run: dotnet restore
- name: Prepare WASM SDKs
run: dotnet msbuild src/WitBindgen/build/WitBindgen.targets /t:PrepareWasmSdks
run: dotnet msbuild src/WitBindgen/build/ByteCodeAlliance.Componentize.DotNet.WitBindgen.targets /t:PrepareWasmSdks
- name: Build
run: dotnet build --no-restore /p:BuildNumber=${{ github.run_number }}
- name: Test
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Requires [.NET 8+](https://dotnet.microsoft.com/en-us/download)

```
## needed to avoid errors with multiple projects calling and downloading the sdks at same time (https://github.com/bytecodealliance/componentize-dotnet/issues/8)
dotnet msbuild src/WitBindgen/build/WitBindgen.targets /t:PrepareWasmSdks
dotnet msbuild src/WitBindgen/build/ByteCodeAlliance.Componentize.DotNet.WitBindgen.targets /t:PrepareWasmSdks
dotnet build
```

Expand Down
2 changes: 1 addition & 1 deletion src/WasmComponent.Sdk/WasmComponent.Sdk.csproj
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="build\WasmComponent.Sdk.props" />
<Import Project="build\ByteCodeAlliance.Componentize.DotNet.Wasm.SDK.props" />

<PropertyGroup>
<PackageId>ByteCodeAlliance.Componentize.DotNet.Wasm.SDK</PackageId>
Expand Down
2 changes: 1 addition & 1 deletion src/WitBindgen/WitBindgen.csproj
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="build\WitBindgen.props" />
<Import Project="build\ByteCodeAlliance.Componentize.DotNet.WitBindgen.props" />

<PropertyGroup>
<PackageId>ByteCodeAlliance.Componentize.DotNet.WitBindgen</PackageId>
Expand Down
File renamed without changes.
File renamed without changes.

0 comments on commit b64e103

Please sign in to comment.