Use Wac for composition #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
commented
Nov 26, 2024
| <Target Name="DownloadWac" Inputs="@(WacOutputs)" Outputs="@(WacOutputs)"> | ||
| <MakeDir Directories="tools\%(WacOutputs.Rid)" /> | ||
| <DownloadFile SourceUrl="$(WacBaseUrl)-%(WacTarget.Identity)" DestinationFolder="tools\%(WacTarget.Rid)" DestinationFileName="wac%(WacTarget.ExeExt)" /> | ||
| <Exec Command="chmod +x tools\%(WacTarget.Rid)\wac" Condition="$([MSBuild]::IsOSPlatform('Linux'))"/> |
There was a problem hiding this comment.
This is a hack to pass CI. Need the wac release process to package it in a Tar file to make it executable
jsturtevant
force-pushed
the
use-wac
branch
2 times, most recently
from
7b0b507 to
9dbcb6c
Compare
Signed-off-by: James Sturtevant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5, Since wasm-tools has a bunch of other useful tools I've kept it a part of the SDK so it's easy to use those tools