cm: implement JSON [un]marshaling for Option types #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
ydnar
reviewed
Mar 7, 2025
| @@ -57,3 +59,25 @@ func (o option[T]) Value() T { | |||
| } | |||
| return o.some | |||
| } | |||
|
|
|||
| // MarshalJSON implements the json.Marshaler interface. | |||
| func (o Option[T]) MarshalJSON() ([]byte, error) { | |||
There was a problem hiding this comment.
Methods should be on option[T] so named option types inherit the methods.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements (naively) option marshaling/unmarshaling for Option types. This case is fairly straightforward, marshal to
nullif None and to the value if present.Opening this as a draft just to ensure that this is a change that's well received that follows contribution structure, open to changing anything here!
Addresses Option un/marshaling for #239