Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Install diesel_cli with just postgres feature #312

Merged

Conversation

joonas
Copy link
Contributor

@joonas joonas commented Jan 20, 2025

I noticed #311 was failing on the diesel_cli install step.

Digging in a bit, I noticed the ubuntu-latest runner image was changed to point from Ubuntu 22.04, which has libsqlite3-dev installed by default, to Ubuntu 24.04 instead and that no longer includes libsqlite3-dev in the default apt packages.

This simply adjusts the features that are enabled from defaults to just postgres, which is what the CI workflow uses.

Additionally I folded in the changes from #313:

Per the failure in #312, Rust 1.84 deprecated wasm32-wasi target, and thus it now needs to be set to either wasm32-wasip1 or wasm32-wasip2.

I wasn't sure if we wanted to target p1 or p2, so I defaulted to p2, but happy to switch it to p1 if that's preferred.

@joonas
Copy link
Contributor Author

joonas commented Jan 20, 2025

@calvinrp PTAL when you get a chance 🙂

@calvinrp calvinrp self-requested a review January 20, 2025 20:23
@calvinrp
Copy link
Collaborator

Thank you

@calvinrp calvinrp merged commit 71aaf56 into bytecodealliance:main Jan 20, 2025
6 checks passed
@joonas joonas deleted the chore/restrict-diesel_cli-features branch January 20, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants