Make Ioctl::opcode a method instead of a constant #1286
+40
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the
Ioctl
trait be compatible with ioctls that take a runtime length value, e.g. these evdev ioctls frominput.h
:These generally specify the length of the passed buffer, so that the driver can copy data into userspace (à la
read()
).rg 'len\)\s*_IO' /usr/include
gives 26 results on my system, so they're not rare, and it'd be great to be able to use theIoctl
trait to wrap them.Prior art:
nix::ioctl_read_buf!()