Refactor diagnostic errors to use miette.
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only the last commit is relevant; I'll rebase once #11 is merged. |
fibonacci1729
approved these changes
Nov 25, 2023
This commit refactors the lexer/ast/resolution errors to be based on `miette` and removes the custom error formatting implementation. The relevant error types also no longer have a lifetime parameter and own the data. Test baselines have been updated to the new error format. The `Span` type has been replaced with `SourceSpan` from `miette`.
The error now includes the previous span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the lexer/ast/resolution errors to be based on
mietteand removes the custom error formatting implementation.
The relevant error types also no longer have a lifetime parameter and own the
data.
Test baselines have been updated to the new error format.
The
Spantype has been replaced withSourceSpanfrommiette.