[instantiation linking] Refactor wasm_runtime_instantiate() #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
force-pushed
the
fix/optimize_runtime_instantiate
branch
from
4016457 to
36646a0
Compare
lum1n0us
changed the title
lum1n0us
requested review from
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
This was referenced Nov 3, 2024
lum1n0us
force-pushed
the
fix/optimize_runtime_instantiate
branch
5 times, most recently
from
edddd11 to
f261840
Compare
lum1n0us
force-pushed
the
fix/optimize_runtime_instantiate
branch
from
f261840 to
b71bee8
Compare
bnason-nf
reviewed
Nov 8, 2024
bnason-nf
reviewed
Nov 8, 2024
bnason-nf
reviewed
Nov 8, 2024
bnason-nf
reviewed
Nov 8, 2024
The main goal is to let existed code run without modification
…ctor related import handling in thread management
- Remove unnecessary blank line in FindWASISDK.cmake for improved readability - Format function declaration for wasm_runtime_destroy_imports for consistency
lum1n0us
force-pushed
the
fix/optimize_runtime_instantiate
branch
from
637f5db to
e7a89ee
Compare
wenyongh
reviewed
Nov 20, 2024
wenyongh
approved these changes
Nov 21, 2024
|
|
||
| WASMExternInstance *spawned_imports = runtime_malloc( | ||
| sizeof(WASMExternInstance) * (uint64)spawned_import_count, NULL, | ||
| error_buf, error_buf_size); |
There was a problem hiding this comment.
An improvement is to malloc memory only when spawned_import_count > 0, so as to avoid warning of allocating memory with size 0.
There was a problem hiding this comment.
Ok. I will finish ⬆️ in #3898
lum1n0us
merged commit 8c48d71
into
bytecodealliance:dev/instantiate_linking
383 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based #3845 and #3887