-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to support WASI on Zephyr #3948
Fixes to support WASI on Zephyr #3948
Conversation
Fixed issues in os_renameat Signed-off-by: Stephen Berard <[email protected]>
There is 1 testing failing above, but I don't believe it's related to this PR. |
It's not related. Don't be worried. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I remember this issue was fixed in main branch and the commits in main branch had been merged into this branch. Maybe you can rebase you code to run CIs again. |
Sure, I'll get this done shortly. |
e3b0244
into
bytecodealliance:dev/zephyr_file_socket
@wenyongh Do we have a plan for when this will be merged into the mainline or do you need me to create a PR for this? |
If there is no another patches for this branch, we can consider merging it to main branch. I think we had better create a new release (WAMR-2.2.1) before merging this branch into main. |
Fixed issues #3311.
@wenyongh I'm merging this to the branch created so that we can review and ensure all the items are addressed prior to merging back to main.