Add support for extended-const to wasm-smith
#1862
Open
+146
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the `extended-const` proposal to the `wasm-smith` generator crate. This is gated behind a new `extended_const_enabled` field in `wasm_smith::Config` This commit additionally refactors the `wasm-smith` test suite and fuzzers in this repository to share the same source for generating a `WasmFeatures` from a `Config`. Finally this also fixes a few minor issues with wide arithmetic, namely it was enabled in fuzzing for components by accident and needed to be added to the `Config`-to-`WasmFeatures` conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the
extended-constproposal to thewasm-smithgenerator crate. This is gated behind a newextended_const_enabledfield inwasm_smith::ConfigThis commit additionally refactors the
wasm-smithtest suite and fuzzers in this repository to share the same source for generating aWasmFeaturesfrom aConfig.Finally this also fixes a few minor issues with wide arithmetic, namely it was enabled in fuzzing for components by accident and needed to be added to the
Config-to-WasmFeaturesconversion.