-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
取色器取色点移出屏幕会出现取色异常的bug #21
Open
longer96
wants to merge
2
commits into
bytedance:develop_nullsafety
Choose a base branch
from
longer96:develop_nullsafety
base: develop_nullsafety
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -75,21 +75,35 @@ class _ColorSuckerState extends State<ColorSucker> { | |||||
} | ||||||
|
||||||
void _onPanUpdate(DragUpdateDetails dragDetails) { | ||||||
_magnifierPosition = | ||||||
dragDetails.globalPosition - _magnifierSize.center(Offset.zero); | ||||||
double newX = dragDetails.globalPosition.dx; | ||||||
double newY = dragDetails.globalPosition.dy; | ||||||
if (newX + (_magnifierSize.width / 2) < 0) { | ||||||
newX = 0; | ||||||
} else if (newX >= _windowSize.width) { | ||||||
newX = _windowSize.width - 1; | ||||||
} | ||||||
|
||||||
if (newY + (_magnifierSize.height / 2) < 0) { | ||||||
newY = 0; | ||||||
} else if (newY + (_magnifierSize.height / 2) > _windowSize.height) { | ||||||
newY = _windowSize.height - 1; | ||||||
} | ||||||
|
||||||
_magnifierPosition = | ||||||
Offset(newX, newY) - _magnifierSize.center(Offset.zero); | ||||||
|
||||||
final Matrix4 newMatrix = Matrix4.identity() | ||||||
..translate(newX, newY) | ||||||
..scale(_scale, _scale) | ||||||
..translate(-newX, -newY); | ||||||
_matrix = newMatrix; | ||||||
_searchPixel(dragDetails.globalPosition); | ||||||
_searchPixel(Offset(newX, newY)); | ||||||
setState(() {}); | ||||||
} | ||||||
|
||||||
void _toolBarPanUpdate(DragUpdateDetails dragDetails) { | ||||||
_toolBarY = dragDetails.globalPosition.dy - 40; | ||||||
if (_toolBarY <= 0) _toolBarY = 0; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. get ✅ |
||||||
setState(() {}); | ||||||
} | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在数值濒临溢出时,
newY
的值会被马上设置为屏幕底部边缘值-1,这会导致在取色器濒临触达屏幕底部时产生“吸附”底部的效果,导致无法取到屏幕最底部的色值。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
非常抱歉,我没有完整的测试就提交了代码。我明天加紧修改