Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

取色器取色点移出屏幕会出现取色异常的bug #21

Open
wants to merge 2 commits into
base: develop_nullsafety
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,35 @@ class _ColorSuckerState extends State<ColorSucker> {
}

void _onPanUpdate(DragUpdateDetails dragDetails) {
_magnifierPosition =
dragDetails.globalPosition - _magnifierSize.center(Offset.zero);
double newX = dragDetails.globalPosition.dx;
double newY = dragDetails.globalPosition.dy;
if (newX + (_magnifierSize.width / 2) < 0) {
newX = 0;
} else if (newX >= _windowSize.width) {
newX = _windowSize.width - 1;
}

if (newY + (_magnifierSize.height / 2) < 0) {
newY = 0;
} else if (newY + (_magnifierSize.height / 2) > _windowSize.height) {
newY = _windowSize.height - 1;
}
Copy link
Collaborator

@smileShirely smileShirely Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在数值濒临溢出时,newY 的值会被马上设置为屏幕底部边缘值-1,这会导致在取色器濒临触达屏幕底部时产生“吸附”底部的效果,导致无法取到屏幕最底部的色值。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
非常抱歉,我没有完整的测试就提交了代码。我明天加紧修改


_magnifierPosition =
Offset(newX, newY) - _magnifierSize.center(Offset.zero);

final Matrix4 newMatrix = Matrix4.identity()
..translate(newX, newY)
..scale(_scale, _scale)
..translate(-newX, -newY);
_matrix = newMatrix;
_searchPixel(dragDetails.globalPosition);
_searchPixel(Offset(newX, newY));
setState(() {});
}

void _toolBarPanUpdate(DragUpdateDetails dragDetails) {
_toolBarY = dragDetails.globalPosition.dy - 40;
if (_toolBarY <= 0) _toolBarY = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (_toolBarY <= 0) _toolBarY = 0;
_toolBarY = max(0, _toolBarY);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get ✅

setState(() {});
}

Expand Down