Make "UploadResult" type public

bytescale · Apr 24, 2024 · 98152df · 98152df
1 parent b6ba4a6
commit 98152df
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/src/private/UploadManagerBase.ts b/src/private/UploadManagerBase.ts
@@ -13,8 +13,7 @@ import { PreUploadInfo } from "./model/PreUploadInfo";
 import { UploadSourceBlob } from "./model/UploadSourceProcessed";
 import { PutUploadPartResult } from "./model/PutUploadPartResult";
 import { AddCancellationHandler } from "./model/AddCancellationHandler";
-import { UploadResult } from "./model/UploadResult";
-import { UploadManagerParams, UploadProgress, UploadSource } from "../public/shared/CommonTypes";
+import { UploadManagerParams, UploadProgress, UploadSource, UploadResult } from "../public/shared/CommonTypes";
 
 /**
  * Methods common to UploadManagerNode and UploadManagerBrowser.

diff --git a/src/private/model/UploadResult.ts b/src/private/model/UploadResult.ts
diff --git a/src/public/shared/CommonTypes.ts b/src/public/shared/CommonTypes.ts
@@ -1,4 +1,4 @@
-import { BeginMultipartUploadRequest } from "./generated";
+import { BeginMultipartUploadRequest, FileDetails } from "./generated";
 
 /**
  * Workaround for tsc aliases, where we cannot export implementation-less modules in our dists.
@@ -23,6 +23,13 @@ export interface UploadProgress {
   progress: number;
 }
 
+export type UploadResult = Omit<FileDetails, "etag"> & {
+  /**
+   * The file's ETag, short for "entity tag", reflects the file's version and changes whenever the file is modified.
+   */
+  etag: string;
+};
+
 export type UploadSource = NodeJS.ReadableStream | BlobLike | Buffer | string;
 
 export interface UploadManagerParams extends Omit<BeginMultipartUploadRequest, "size" | "protocol"> {